New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jsonrpc): add support for allow-insecure-unlock #2375
feat(jsonrpc): add support for allow-insecure-unlock #2375
Conversation
Allow insecure account unlocking when account-related RPCs are exposed by http
Hey @timwhite2, this is cool! Thanks for the implementation of this feature. Will look into it ASAP |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2375 +/- ##
===========================================
- Coverage 70.45% 59.55% -10.90%
===========================================
Files 293 341 +48
Lines 22559 21598 -961
===========================================
- Hits 15893 12862 -3031
- Misses 5800 7689 +1889
- Partials 866 1047 +181
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @timwhite2!!
Left one comment.
Also, please add a changelog entry
1.remove JSONRPC.Enable check 2.add changelog 3.modify JSONRPC.Enable description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Thanks for this great contribution @timwhite2!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for the contribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the tests that are not passing?
Sure |
Co-authored-by: Ramiro Carlucho <ramirocarlucho@gmail.com>
The other errors seem to have nothing to do with this branch |
@ramacarlucho It seems that all required checks have passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, however I see it's being enabled in a lot of places but it's usage is actually not tested. There should be dedicated tests added to showcase the feature and that it is working, if we're going to enable it.
Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
Signed-off-by: Tom <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> Signed-off-by: Tom <54514587+GAtom22@users.noreply.github.com>
Allow insecure account unlocking when account-related RPCs are exposed by http
Description
Closes: #1657
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.
I have...
Unreleased
section inCHANGELOG.md