Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sketching out how this all ought to work. Currently I have:
A load of intrinsics
widen_cast
for widening conversionsnarrow_cast
for narrowing conversions (returnsOptional
)signed_cast
for signedness conversions (returnsOptional
)The intrinsics aren’t yet implemented, and this doesn’t cover coercions with wraparound/truncation. I’d like to have wrapper types like
Wrapped<T>
,Unchecked<T>
, andSaturating<T>
for different overflow behaviours—that depends on making arithmetic+Fail
by default and making+Fail
an implicit permission.Originally I intended to have a single
cast
trait, where the instances would beOptional
in the result type for narrowing conversions, and I think that might be more ergonomic, but it might also require more type annotations and/or lead to bugs because it’s not very explicit.