-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: drop down gap #2007
fix: drop down gap #2007
Conversation
🦋 Changeset detectedLatest commit: adf8b4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for next-docs-evidence ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for evidence-test-env ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for evidence-development-workspace ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
packages/ui/core-components/src/lib/atoms/inputs/dropdown/Dropdown.svelte
Outdated
Show resolved
Hide resolved
packages/ui/core-components/src/lib/atoms/inputs/dropdown/Dropdown.svelte
Outdated
Show resolved
Hide resolved
packages/ui/core-components/src/lib/atoms/inputs/dropdown/Virtual.svelte
Outdated
Show resolved
Hide resolved
packages/ui/core-components/src/lib/atoms/inputs/dropdown/Virtual.svelte
Outdated
Show resolved
Hide resolved
packages/ui/core-components/src/lib/atoms/inputs/dropdown/Virtual.svelte
Outdated
Show resolved
Hide resolved
packages/ui/core-components/src/lib/atoms/inputs/dropdown/Virtual.svelte
Outdated
Show resolved
Hide resolved
packages/ui/core-components/src/lib/atoms/inputs/dropdown/Dropdown.svelte
Outdated
Show resolved
Hide resolved
packages/ui/core-components/src/lib/atoms/inputs/dropdown/Dropdown.svelte
Outdated
Show resolved
Hide resolved
@kwongz hitting the ground running, nice! A couple things I noticed:
@ItsMeBrianD feel free to weigh in also, but would it make sense to have the behaviour be something more like:
I think that would cover the multi-line and search scenarios while also removing the gap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
Thanks @mcrascal! Sound good, get working on this! |
…ook dropdown options for testing
Added conditional rendering in the Dropdown.svelte file, Renders scroll-able Virtual List with 5 or more options Dropdowns with less then 5 options will render DropdownOptionDisplay component with a regular div container to manage the height of the contents Example 1. - 4 options with Line breaking Example 2. - 2 options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should be gitignored
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Added the hashes.json to the gitignore, not too sure how it ended up there will speak to Brian about it tomorrow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very excellent. No notes. One note.
@kwongz Massive! |
Description
Checklist
I have added to the docs where applicableI have added to the VS Code extension where applicable