Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom breadcrumbs #1964

Open
wants to merge 15 commits into
base: next
Choose a base branch
from
Open

Custom breadcrumbs #1964

wants to merge 15 commits into from

Conversation

csjh
Copy link
Contributor

@csjh csjh commented May 2, 2024

Description

Enables custom handling of breadcrumb naming via frontmatter

Example (from test-env):

---
breadcrumb: "SELECT first_name || ' ' || last_name || '''s ' || order_month || ' Order' as breadcrumb FROM orders WHERE id = '{params.order_id}'"
---

Order #{params.order_id}
image

Checklist

  • I have added a changeset
  • I have added to the docs where applicable

Copy link

changeset-bot bot commented May 2, 2024

🦋 Changeset detected

Latest commit: b003c04

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@evidence-dev/evidence Major
@evidence-dev/core-components Minor
my-evidence-project Patch
evidence-test-environment Patch
@evidence-dev/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented May 2, 2024

Deploy Preview for evidence-development-workspace ready!

Name Link
🔨 Latest commit b003c04
🔍 Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/66352f0de7d6f900082fc116
😎 Deploy Preview https://deploy-preview-1964--evidence-development-workspace.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 2, 2024

Deploy Preview for next-docs-evidence ready!

Name Link
🔨 Latest commit b003c04
🔍 Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/66352f0dbdcfa60008623112
😎 Deploy Preview https://deploy-preview-1964--next-docs-evidence.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hughess
Copy link
Member

hughess commented May 3, 2024

I think the build error is coming from linking to parent directories that don't have an index page

@ItsMeBrianD ItsMeBrianD self-assigned this May 21, 2024
@ItsMeBrianD ItsMeBrianD requested a review from mcrascal May 21, 2024 15:33
@@ -0,0 +1,5 @@
---
breadcrumb: "SELECT first_name || ' ' || last_name || '''s ' || order_month || ' Order' as breadcrumb FROM orders WHERE id = '{params.order_id}'"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
breadcrumb: "SELECT first_name || ' ' || last_name || '''s ' || order_month || ' Order' as breadcrumb FROM orders WHERE id = '{params.order_id}'"
breadcrumb: "SELECT first_name || ' ' || last_name || '''s ' || order_month || ' Order' as breadcrumb FROM orders WHERE id = '${params.order_id}'"

does this need a $

if not then it diverges from our SQL APIs elsewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants