Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metadata from first paragraph and heading #1922

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

AyushAgrawal-A2
Copy link
Contributor

@AyushAgrawal-A2 AyushAgrawal-A2 commented Apr 19, 2024

Description

close #1903

Changes:

  • Added pre-processor to extract first h1-heading and paragraph from svelte markup to be used as page meta title and description, if frontmatter title / description is missing.

Checklist

  • For UI or styling changes, I have added a screenshot or gif showing before & after
  • I have added a changeset
  • I have added to the docs where applicable
  • I have added to the VS Code extension where applicable

Copy link

changeset-bot bot commented Apr 19, 2024

🦋 Changeset detected

Latest commit: d788ce1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@evidence-dev/preprocess Patch
@evidence-dev/evidence Patch
@evidence-dev/components Patch
my-evidence-project Patch
evidence-test-environment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for next-docs-evidence ready!

Name Link
🔨 Latest commit d788ce1
🔍 Latest deploy log https://app.netlify.com/sites/next-docs-evidence/deploys/66468174b959340008e9c224
😎 Deploy Preview https://deploy-preview-1922--next-docs-evidence.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for evidence-development-workspace ready!

Name Link
🔨 Latest commit d788ce1
🔍 Latest deploy log https://app.netlify.com/sites/evidence-development-workspace/deploys/664681748896430008f244a5
😎 Deploy Preview https://deploy-preview-1922--evidence-development-workspace.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AyushAgrawal-A2 AyushAgrawal-A2 changed the title Ayush/1903 feat: add metadata from first paragraph and heading Apr 19, 2024
@AyushAgrawal-A2 AyushAgrawal-A2 force-pushed the ayush/1903 branch 2 times, most recently from 91d9869 to f3db53f Compare April 20, 2024 00:31
Comment on lines 2 to 16
'@evidence-dev/faker-datasource': minor
'@evidence-dev/mssql': minor
'@evidence-dev/snowflake': minor
'@evidence-dev/evidence': minor
'@evidence-dev/component-utilities': minor
'@evidence-dev/db-orchestrator': minor
'@evidence-dev/plugin-connector': minor
'@evidence-dev/preprocess': minor
'@evidence-dev/query-store': minor
'@evidence-dev/sdk': minor
'@evidence-dev/universal-sql': minor
'@evidence-dev/core-components': minor
'my-evidence-project': minor
'@evidence-dev/components': minor
'evidence-test-environment': minor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only be a patch change for the impacted package (in this case preprocess)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ItsMeBrianD
sure will change it, shall I also revert the pnpm.lock file commit.
Without commiting pnpm.lock file, previews were not getting deployed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No the lock file is okay to include!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

packages/lib/preprocess/index.cjs Show resolved Hide resolved
Copy link

netlify bot commented May 16, 2024

Deploy Preview for evidence-test-env ready!

Name Link
🔨 Latest commit d788ce1
🔍 Latest deploy log https://app.netlify.com/sites/evidence-test-env/deploys/664681741adc3400088a2cf8
😎 Deploy Preview https://deploy-preview-1922--evidence-test-env.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the first paragraph of markdown file as meta description
2 participants