Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move UI Components tests inside of the packages/ui-components folder #253

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

thomascullen
Copy link
Member

@thomascullen thomascullen commented Jan 4, 2024

Why

Currently all of the tests are outside of the packages that they are testing. We want to change this so that the tests are colocated with the code that they are testing.

How

This moves the UI Components tests into the packages/ui-components folder.

@thomascullen thomascullen requested a review from a team as a code owner January 4, 2024 09:48
Copy link

changeset-bot bot commented Jan 4, 2024

⚠️ No Changeset found

Latest commit: bfa7ddc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
typescript 5.3.3 None +0 32 MB typescript-bot

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a dedicated tests package.json?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shout. Trying to do this in a few PR's rather than a massive one so just moved the old package in but will merge them. 👌

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats fair feel free to come back later and remove useless files if you'd like

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can dump these changelogs as changeset shouldn't try deploying them once their package.json is gone

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the other package.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the other changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants