Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-62]: Fix closing li tag, fix nested list #63

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

FJCrux
Copy link

@FJCrux FJCrux commented Apr 27, 2020

There is fix for #62
You can find google doc with fixed addon version here https://docs.google.com/document/d/1VnPTSkm2AxzR2Up0tBXjRx5vvktaOwgKxLB2tALREh0/edit?usp=sharing

@evbacher evbacher changed the base branch from master to dev April 27, 2020 21:13
@evbacher
Copy link
Owner

Thanks for attacking the list bugs!

Your fix seems to work on your test file, but it breaks other list cases. Can you test it out on the dev verification file as described here: https://github.com/evbacher/gd2md-html/blob/master/dev.md#modifying-docs-to-markdown-code

Also, let me know if you have any suggestions for simplifying this process. This is my first real open-source project.

@FJCrux FJCrux force-pushed the ISSUE-62__close-list-item-and-nested-list branch from 28420f1 to 7053d5f Compare April 28, 2020 11:10
@FJCrux
Copy link
Author

FJCrux commented Apr 28, 2020

I checked the test files, but I had doubts whether there were problems there:

  1. In case Lists with code blocks, first element must include code block, but code block is not a part list item
  2. In part $ cat file | grep dog | wc html look like wrong even in master branch(

If you meant other cases, please write which ones.

P.S. I will update doc file for your version and update html and md verification for visual comparison

@evbacher
Copy link
Owner

I'll try to get time to take another look at this.

But you'll also need to sign the CLA referred to in CONTRIBUTING.md. I cannot accept code into this repo without that agreement.

@FJCrux
Copy link
Author

FJCrux commented Apr 30, 2020

I sign the CLA

@bravetheheat
Copy link

@evbacher is there anything I can do to help get this merged?

@pencerw
Copy link

pencerw commented Jul 9, 2021

☝️ ditto! would love this bug fix and am happy to chip in to get it done

@evbacher
Copy link
Owner

evbacher commented Jul 9, 2021

It breaks other test cases, so I am not going to merge. I'll check again and let you know which cases it breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants