Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified for custom RPC #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IoanAlin
Copy link

Modified for custom RPC

Modified for custom RPC
Copy link
Owner

@ethernity-cloud ethernity-cloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Thank you for the contribution Alin, unfortunately the PR is incomplete. The following aspects have to be covered by the current pull request:

  • This setting should be available at installation time, like all the other settings, so additional files have to be updated so any installation can have this configuration, similar to the IPFS host setting.
  • Please use environment variables as the rest of the code does already, to keep compatibility with previous versions of the agent.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants