Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic release #330

Merged
merged 28 commits into from May 2, 2024
Merged

Deterministic release #330

merged 28 commits into from May 2, 2024

Conversation

rapidddenis
Copy link
Collaborator

@rapidddenis rapidddenis commented Apr 13, 2024

  • admin computes service addresses to deploy
  • admin creates release
  • manager prepares release, submits salt and config (previously computed addresses + authorizations)
  • manager deploys and registers services in corresponding order
  • admin activates the release (or skips)

Copy link
Contributor

Todo Commenter

contracts/distribution/DistributionService.sol
TODO:
  • zero should return false Line: 329
contracts/product/ApplicationService.sol
TODO:
  • add validations (see create bundle in pool service) Line: 100
  • add logging Line: 147
contracts/product/PolicyService.sol
TODO:
  • add logging Line: 170
  • add logging Line: 219
  • add logging Line: 238
  • add logging Line: 376

@rapidddenis Please take a look 👀

@rapidddenis rapidddenis merged commit 7c6faf6 into develop May 2, 2024
11 checks passed
@rapidddenis rapidddenis deleted the determenistic-release branch May 2, 2024 12:32
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant