Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for fromV1 #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chikeichan
Copy link

Relates to #26

Adding a few missing negative tests. Much of the remaining missing coverage seem to be from the _typeof polyfills.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.6%) to 94.774% when pulling 0a5b8ad on chikeichan:increase-coverage into 830307c on ethereumjs:master.

@holgerd77
Copy link
Member

Hi Jacky,
sorry that this never got merged. Would it be ok if I take the code parts with the tests of your PR manually and integrate into the updates TypeScript test files? Or would you alternatively even have some time to update the PR?

Hope everything is fine, all the best
Holger

@holgerd77
Copy link
Member

Hi @chikeichan, would really be happy on an answer here 😀 (see comment above), otherwise I would need to close which would be a bit a pity.

All the best
Holger

@holgerd77
Copy link
Member

(I know it is an absurdly late reaction here, but from the current PoV this is the only thing I can do)

@chikeichan
Copy link
Author

Hi Jacky,
sorry that this never got merged. Would it be ok if I take the code parts with the tests of your PR manually and integrate into the updates TypeScript test files? Or would you alternatively even have some time to update the PR?

Hope everything is fine, all the best
Holger

Hi @holgerd77 - hope all is well! please fell free to take the code parts with the tests and integrate. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants