fix generate now can't throw exception

[vird]

Based on: fffffffffffffffffffffffffffffffebaaedce6af48a03bbfd25e8cd0364141
Probability of throw was ~1/2**499
But after fix it should never throw

[holgerd77]

Hi there, thanks for the PR! 🙂

Could you please give some more context and explain what you are doing here?

[coveralls]

Coverage increased (+0.05%) to 85.036% when pulling 6ee26f6 on vird:fix/generate_now_cant_throw_exception into 83c1b1a on ethereumjs:master.

[vird]

randomBytes(32) is used in current implementation of .generate() for generating new wallet. But this is not 100% correct way to properly generate ECDSA point for private key. My fix allows code to be formally correct and never throw exception (even with astronomically low probability)

[holgerd77]

Thanks for the explanation.

Can we update here that only this specific error is ignored and all other errors rethrown? Otherwise all other errors will get hidden with this implementation.

Also: can you add a test case which would fail before the change and pass afterwards?

[vird]

I made better implementation, but it's almost impossible to mock randomBytes. Because randombytes module uses
module.exports = require('crypto').randomBytes
this implementation. So mocking crypto.randomBytes will have no effect, mocking result of require is impossible (or I don't know how to do that), and mocking whole require is kinda overkill