fix estimateGas #3416
Merged
fix estimateGas #3416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,7 +29,7 @@ import type { EthereumClient } from '../../index.js' | |||
| import type { EthProtocol } from '../../net/protocol/index.js' | |||
| import type { FullEthereumService, Service } from '../../service/index.js' | |||
| import type { RpcTx } from '../types.js' | |||
| import type { Block, JsonRpcBlock } from '@ethereumjs/block' | |||
| import type { JsonRpcBlock } from '@ethereumjs/block' | |||
There was a problem hiding this comment.
How come this is added but nothing is done with it in this PR? I don't see anything in the diff 🤔
There was a problem hiding this comment.
It should have moved block from a type import to a regular import
There was a problem hiding this comment.
Oh right yes this makes sense, thanks
There was a problem hiding this comment.
(its actually in the diff 😅 - time to call it a day I guess 😄 )
|
I have further cleaned up some default values (the estimateGas tests were failing) such that the right base fee is used on the block. |
jochem-brouwer
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.