Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser: fix peer dependency issue #3383

Closed
wants to merge 2 commits into from

Conversation

gabrocheleau
Copy link
Contributor

This PR fixes this peer dependency issue that appeared when running npm run install-browser-deps

> npm install webdriverio @vitest/browser web-streams-polyfill

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: root@undefined
npm ERR! Found: vitest@1.5.0
npm ERR! node_modules/vitest
npm ERR!   peer vitest@"1.5.0" from @vitest/coverage-v8@1.5.0
npm ERR!   node_modules/@vitest/coverage-v8
npm ERR!     dev @vitest/coverage-v8@"^1.2.2" from the root project
npm ERR!   peer vitest@"1.5.0" from @vitest/ui@1.5.0
npm ERR!   node_modules/@vitest/ui
npm ERR!     peerOptional @vitest/ui@"1.5.0" from vitest@1.5.0
npm ERR!     dev @vitest/ui@"^1.2.2" from the root project
npm ERR!   1 more (the root project)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peerOptional @vitest/browser@"^1.5.2" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: vitest@1.5.2
npm ERR! node_modules/vitest
npm ERR!   peer vitest@"1.5.2" from @vitest/browser@1.5.2
npm ERR!   node_modules/@vitest/browser
npm ERR!     peerOptional @vitest/browser@"^1.5.2" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@gabrocheleau gabrocheleau added package: monorepo PR state: needs review type: CI dependencies Pull requests that update a dependency file target: master (v7) Work to be done towards master branch type: maintenance labels Apr 27, 2024
@acolytec3
Copy link
Contributor

Sadly, we still have this "failed to fetch dynamically imported module" thing. I saw this when I was trying to fix via #3369. I think there is still an obscure browser related testing bug in vitest.

@gabrocheleau
Copy link
Contributor Author

Sadly, we still have this "failed to fetch dynamically imported module" thing. I saw this when I was trying to fix via #3369. I think there is still an obscure browser related testing bug in vitest.

Ah! missed that other PR. Will close this on in favor of #3369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file package: monorepo PR state: needs review target: master (v7) Work to be done towards master branch type: CI type: maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants