monorepo: revert and adjust some prefixedHexTypes #3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolytec3
approved these changes
Apr 28, 2024
|
Cool 🎉, can you also add a note to #3216 ? |
holgerd77
reviewed
Apr 29, 2024
| td?: BigIntLike | ||
| blockNumber?: BigIntLike | string | ||
| timestamp?: BigIntLike | string | ||
| td?: BigIntLike | string |
There was a problem hiding this comment.
Oh. This seems wrong I guess?
|
I could instantly spot too missed instances, (or are these not breaking for some reasons?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts some updates that had been made to
stringin #3348 and #3357, where string types were updated toPrefixedHexStringwhen that was relevant, but this can lead to breaking changes in certain contexts. I've reverted what seemed like the most obvious common usages (e.g. block or common types that can be used externally). Instead of actually reverting tostring, I updated the types toPrefixedHexString | stringso that we can easily eventually removestringfully. I've also added TODO's above each of these instances so we can quickly retieve these instances and do that eventually.