Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ethereum-tests to 13.2 #3324

Closed
wants to merge 4 commits into from
Closed

Update ethereum-tests to 13.2 #3324

wants to merge 4 commits into from

Conversation

jochem-brouwer
Copy link
Member

@jochem-brouwer jochem-brouwer commented Mar 16, 2024

Do not merge, the ethereum/tests are likely wrong. These commits likely have to be deleted:

66a1918
f841f9d

With these hotfixes the new tests pass: https://github.com/ethereumjs/ethereumjs-monorepo/actions/runs/8316887875/job/22756952650?pr=3324

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 20.83333% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 86.88%. Comparing base (a70312d) to head (f841f9d).

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.43% <ø> (ø)
blockchain 91.61% <ø> (ø)
client 84.85% <ø> (ø)
common 98.43% <ø> (ø)
devp2p 82.12% <ø> (ø)
ethash ∅ <ø> (∅)
evm 74.16% <ø> (ø)
genesis 99.98% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 77.00% <ø> (ø)
trie 89.32% <ø> (ø)
tx 95.08% <ø> (ø)
util 89.34% <ø> (ø)
vm 79.29% <20.83%> (-0.59%) ⬇️
wallet 88.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jochem-brouwer
Copy link
Member Author

See #3404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant