Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-6110: Supply Validator Deposits on Chain #3303

Closed
wants to merge 45 commits into from

Conversation

scorbajio
Copy link
Contributor

This PR implements EIP-6110 and addresses issue #3299.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 58.18815% with 120 lines in your changes are missing coverage. Please review.

Project coverage is 87.55%. Comparing base (61acbd3) to head (c1e6809).
Report is 12 commits behind head on master.

❗ Current head c1e6809 differs from pull request most recent head 9055185. Consider uploading reports for the commit 9055185 to get more accurate results

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 85.80% <69.91%> (?)
blockchain 91.26% <48.14%> (?)
common 98.44% <100.00%> (?)
evm 73.71% <100.00%> (?)
genesis 99.98% <ø> (?)
statemanager 76.15% <ø> (?)
trie 89.28% <ø> (?)
tx 95.08% <ø> (+9.29%) ⬆️
util 81.58% <43.92%> (?)
vm 79.16% <61.29%> (?)
wallet 88.35% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jochem-brouwer
Copy link
Member

I've pointed #3336 towards this branch :)

Before we merge this one into master, we should ensure that we can can still use Verkle, and possibly also use Verkle together with 6110 + 7002.

@holgerd77
Copy link
Member

Ugh.

Now having read this EIP for the first time I’m realizing what a complex beast this is, always considered this more as some „side EIP“. 🤯

@scorbajio Congrats on that, this looks already pretty great! 🤩 Really blown away by the amount of code already touched here!

TransactionsBytes,
UncleHeadersBytes,
WithdrawalsBytes,
DepositsBytes,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is going to be before or after ExecutionWitnessBytes in Prague.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExecutionWitness is for Verkle which is not scheduled for Prague, so Deposits can always be placed before ExecutionWitness.

comment: 'Supply validator deposits on chain',
url: 'https://eips.ethereum.org/EIPS/eip-6110',
status: Status.Draft,
minimumHardfork: Hardfork.Cancun,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minimumHardfork is not the inclusion HF, but the first HF from which this EIP can be run in isolation (so: all pre-requisits for the EIP are met). So we can (should) switch to Cancun here, just as some additional context.

@acolytec3 acolytec3 mentioned this pull request May 2, 2024
@scorbajio
Copy link
Contributor Author

Implementation of EIP-6110 is being continued at #3390.

@scorbajio scorbajio closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants