New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the rawDecode to utils toBuffer #53
base: master
Are you sure you want to change the base?
Conversation
This caused me a heap of problems decoding an output for Parity, and I imagine it's likely to help others down the road.
@VoR0220 what is the problem this is solving? |
Well for me, this wasn't compiling previously before I popped this in. Might be an OS X issue, might be an NPM issue, I'm not certain. I believe it had something to do with the way that it assumed the input and didn't convert it prior to. Either way, this converts any inputs into a buffer beforehand and is therefore a better way of going about it from my perspective. |
I think the main motivation was not require strict inputs and not introduce the mess other ethereumjs libraries have with the To be honest I think it shouldn't even expect a hex string, rather a |
Is there anything preventing this from being merged? We were running into this error when decoding |
fixes:
And we're running into this on OSX. |
@se3000 What do you take as input so that this error emerges? |
@axic Can't really judge from the discussion if this is a valid PR or not. |
This caused me a heap of problems decoding an output for Parity, and I imagine it's likely to help others down the road.