Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove constructor pattern #3

Closed
wants to merge 2 commits into from
Closed

Conversation

tarrencev
Copy link

This removes the use of the constructor pattern since there is no need to instantiate a library of pure functions. Makes for a much cleaner interface imo.

@axic

@axic
Copy link
Member

axic commented Jan 18, 2016

Thank you. Initially the API was meant to be similar to web3.js in the sense of parsing an ABI JSON description would lead to an object with function calls, hence the constructor based code.

I don't think we'll end up that way, so probably I'll merge this.

We also started a discussion on the API here: #2

@tarrencev
Copy link
Author

Cool, sounds good. Would be happy to contribute!

@axic
Copy link
Member

axic commented Feb 3, 2016

@tarrencev do you want to rebase this?

I do like the following better though:

var ABI = {}

ABI.rawEncode = 
...

module.exports = ABI;

@tarrencev
Copy link
Author

@axic sure no problem

@axic axic closed this in 0e5dd6a Mar 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants