Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also need to update the apps/remix-ide/src/index.html and all the other index.html files with the correct import css files and also all the apps index.html of the css files. For example apps/circuit-compiler/src/index.html
The apps like the circuit-compiler/index.html import this:
The kit is downloaded as the latest version. The latest version currently is 6.5.2. It looks like the apps need to be pegged to a specific version.
I believe that the desktop needs the file all.css but this is not optimized and is probably too big for the online IDE: see
https://docs.fontawesome.com/web/setup/host-yourself/webfonts
" And if you are using all.js or all.css, your custom icons will be included in those, though for performance reasons, we recommend adding just the files you are using in your project."
And on a smaller note, the kit has a file in the css folder called fontawesome.min.css and in our assets/css folder there is a file called: font-awesome.min.css. So it looks like a little cleanup of the necessary css files is needed.