Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest font-awesome kit #4754

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update to latest font-awesome kit #4754

wants to merge 2 commits into from

Conversation

ryestew
Copy link
Collaborator

@ryestew ryestew commented Apr 22, 2024

We also need to update the apps/remix-ide/src/index.html and all the other index.html files with the correct import css files and also all the apps index.html of the css files. For example apps/circuit-compiler/src/index.html

The apps like the circuit-compiler/index.html import this:

The kit is downloaded as the latest version. The latest version currently is 6.5.2. It looks like the apps need to be pegged to a specific version.

I believe that the desktop needs the file all.css but this is not optimized and is probably too big for the online IDE: see
https://docs.fontawesome.com/web/setup/host-yourself/webfonts
" And if you are using all.js or all.css, your custom icons will be included in those, though for performance reasons, we recommend adding just the files you are using in your project."

And on a smaller note, the kit has a file in the css folder called fontawesome.min.css and in our assets/css folder there is a file called: font-awesome.min.css. So it looks like a little cleanup of the necessary css files is needed.

  • So I'd like @LianaHus, @joeizang, @bunsenstraat to weigh in to clear up the issue of all.css which only needed for the desktop app
  • Someone else to take over this PR - or to work with me to get the correct links for index.html files.
  • Someone else to take over this PR - or to work with me to get the minimum files needed from the downloaded kit - that is if we don't want to use all.css

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 254f40c
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/6626a68c66110c0008824fa3
😎 Deploy Preview https://deploy-preview-4754--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joeizang
Copy link
Collaborator

@ryestew I think pr can be closed as fontawesome has been updated by yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants