Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add grid view providers #4753

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add grid view providers #4753

wants to merge 2 commits into from

Conversation

yann300
Copy link
Contributor

@yann300 yann300 commented Apr 22, 2024 •
edited

This adds a new plugin which expand the provider selection component.

@yann300 yann300 added the WIP label Apr 22, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 22, 2024 •
edited

✅ Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit fc195c6
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/6641cbd5f8c98900084dbb7e
😎 Deploy Preview https://deploy-preview-4753--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yann300 yann300 requested a review from LianaHus April 25, 2024 13:50
@yann300 yann300 force-pushed the providers_grid branch 8 times, most recently from c6b24ff to 25e9ed1 Compare April 30, 2024 06:52
@yann300 yann300 added ready-to-review PR ready to review and removed WIP labels Apr 30, 2024
@yann300 yann300 added this to In progress in 0.49.0 - Feature Freeze 20/05 via automation Apr 30, 2024
@yann300 yann300 force-pushed the providers_grid branch 3 times, most recently from 53f8c99 to c785e4b Compare April 30, 2024 13:39
@Aniket-Engg
Copy link
Collaborator

Had a look. I think it is not quite user friendly yet.

Aniket-Engg
Aniket-Engg reviewed May 7, 2024
View reviewed changes
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • If Grid Providers is opened and we open Home Tab and click on pin another chain, it doesn't show grid providers tab
  • If we unpin vm-cancun, there is no selection in environment tab
  • We need to set the behavious if each environment is unpinned

@yann300 yann300 force-pushed the providers_grid branch 3 times, most recently from 4c25fdb to 620fd9f Compare May 10, 2024 08:57
Aniket-Engg
Aniket-Engg reviewed May 10, 2024
View reviewed changes
Copy link
Collaborator

@Aniket-Engg Aniket-Engg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we unpin vm-cancun, there is no selection in environment tab This issue is still there.
Also, if you unpin an environment, it doesn't change the pin color and then we can not pin it again

@yann300 yann300 self-assigned this May 13, 2024
@yann300 yann300 force-pushed the providers_grid branch 2 times, most recently from 0f99567 to c63731e Compare May 13, 2024 08:06
@yann300
- don't unpin if selected provider
fc195c6 
 - focus on gridprovider
 - show no provider pinned
@Aniket-Engg Aniket-Engg removed this from In progress in 0.49.0 - Feature Freeze 20/05 May 20, 2024
@Aniket-Engg Aniket-Engg added this to In progress in v0.50.0 - Feature Freeze 03/06 via automation May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aniket-Engg Aniket-Engg Aniket-Engg left review comments

@LianaHus LianaHus Awaiting requested review from LianaHus

At least 1 approving review is required to merge this pull request.

Assignees

@yann300 yann300

Labels
ready-to-review PR ready to review translation
Projects
v0.50.0 - Feature Freeze 03/06
In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yann300 @Aniket-Engg