New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remix RTD Docs design revamp and unification #3198
base: master
Are you sure you want to change the base?
Conversation
outline and solid variants
linting
polymorphism with other menu handlers
hide skip nav link to avoid overflow
highlight active language
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wackerow minor UI issue
The base font seems to be Helvetica, but in this case, its using Arial
light|dark|black, sun|sunset|moon icons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Small problem with the sidebar. Long titles cause horizontal scrolling, which I'm not sure we want. This example is in the Spanish version
This scrolling is also going to break a bit the mobile experience.
-
Probably not something related to this revamp but just noted that we have this copy where we mention that we have more translations than the ones we have on the menu
Last observation, the docs are translated into 3 languages while the homepage is in 2. Spanish is the difference. Probably not a problem, just wanted to mention it in case we need consistency there.
Thanks @pettinarip! Few responses and follow-up questions:
I'm not getting this... are you still seeing this? If so, let me know what browser you're using.
Thanks, I'll look into and try to get a patch up.
Yeah this would be out of scope here... would suggest the team edits that once the upgrade is complete with the latest languages.
I'm grabbing the language codes from the "flyover" menu that generates automatically by RTD (the names don't populate, just the codes).. from there I'm feeding it to |
Just pushed a patch for the text-overflow... @pettinarip let me know if you're still getting the Arial bug, otherwise I think this is good for another review. |
I see this just in Brave (Version 1.66.110 Chromium: 125.0.6422.60 (Official Build) (64-bit)). Chrome and FF are working fine. Minor issue I'd say. Anyway, for some reason, the styles for this button are overridden by the browser's styles. |
Got it. All working fine from my side now. |
Description
Brings new menu navigation and color themes in tandem with unifying updates to the Remix Project homepage.
Preview URL