Remove unnecessary receipt derivation logic #29670
Open
+168
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for a single derivation
pengin7384
requested review from
karalabe,
holiman and
rjl493456442
as code owners
holiman
reviewed
Apr 30, 2024
core/rawdb/accessors_indexes.go
Outdated
|
|
||
| // Find a match tx and derive receipt fields | ||
| for txIndex, tx := range blockBody.Transactions { | ||
| if tx.Hash() == txHash { |
There was a problem hiding this comment.
Suggested change
| if tx.Hash() == txHash { | |
| if tx.Hash() != txHash { | |
| continue | |
| } |
if you invert this, you can un-indent the whole clause below for great good
There was a problem hiding this comment.
Looks good.
Below lines need to be un-indent, so I'll push a new commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary receipt derivation logic.
More details are in the issue.
Related issue: #29669