tracer: use proper base fee in tests #28775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1na
reviewed
Jan 9, 2024
eth/tracers/internal/tracetest/testdata/prestate_tracer_with_diff_mode/create_failed.json
Outdated
Show resolved
Hide resolved
palango
force-pushed
the
palango/tracer-test-bug
branch
4 times, most recently
from
8a9c9ad
to
c5ca0b9
Compare
s1na
approved these changes
Jan 11, 2024
|
The failing tests seems to be flaky, no caused by this PR |
palango
force-pushed
the
palango/tracer-test-bug
branch
6 times, most recently
from
356b49a
to
ce36f4d
Compare
holiman
changed the title
palango
force-pushed
the
palango/tracer-test-bug
branch
from
ce36f4d
to
69d9cd4
Compare
|
I'm not sure why CI doesn't turn green. There seem to be some flaky tests, especially |
Don't worry about it. And no need to force-push to trigger it, we can rerun the ones that fail |
|
Re-running the failed tests 🤞 sometimes we have to do this a couple of times to get the green check |
Dergarcon
pushed a commit
to specialmechanisms/mev-geth-0x2mev
that referenced
this pull request
Jan 31, 2024
In the tracing tests, the base fee was generally set to nil. This commit changes this to pass the proper base instead, and fixes the few tests which become broken by the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on another issue, I found that in the tracing tests the base fee is generally set to
nil(see https://github.com/ethereum/go-ethereum/blob/master/eth/tracers/internal/tracetest/prestate_test.go#L120). Changing this to pass the proper base fee works for most tests, butTestPrestateWithDiffModeTracerruns into problems in thecreate_failed.jsontest case.Here the base fee is 51088069741, and the transactions fee limit is set to 112855938170. The transactions tip cap is 1500000000. This leads to a gas price of 112855938170 when the base fee is not set, but 52588069741 when the base fee is set.
The difference between those two values is 60267868429, multiplied by the gas limit of the transaction (176545) this makes up a balance difference of 10639990831797805, which is changes in the test file.
Resolves #28773