core: Refactor NewBlockchain -- Add blockChainConfig #28771
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR modifies
core.NewBlockChain
and adds in a newblockChainConfig
struct along with supporting types and methods.Why
Issue #20280 mentions that the number of arguments to
core.NewBlockChain
had gotten out of hand and a config structure was desired. This issue was raised 5 years ago and the amount of refactoring needed has increased since.Testing
Reference