Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esy-bash as optional dependency #1484

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ManasJayanth
Copy link
Member

This should give npm client a better opportunity to cache esy-bash, thereby reducing esy installation times on Windows. On other platforms, this will be a noop

1. We dont install esy-bash via postinstall.js anymore
2. We generate release package.json from development package.json. So,
less scope of esy-bash versions going out of sync
@ManasJayanth ManasJayanth force-pushed the prometheansacrifice/esy-bash-as-optional-dependency branch from 9d8f9e8 to 6ef8532 Compare July 1, 2023 00:23
@ManasJayanth ManasJayanth force-pushed the prometheansacrifice/esy-bash-as-optional-dependency branch from 6ef8532 to 0336f22 Compare July 1, 2023 01:20
@ManasJayanth
Copy link
Member Author

Nix build is failing because of a network issue

warning: error: unable to download 'https://gitlab.inria.fr/fpottier/fix/-/archive/20220121/archive.tar.gz': Couldn't connect to server ([7](https://github.com/esy/esy/actions/runs/5428343543/jobs/9872745534#step:4:8)); retrying in 268 ms
warning: error: unable to download 'https://gitlab.inria.fr/fpottier/fix/-/archive/20220121/archive.tar.gz': Couldn't connect to server (7); retrying in 615 ms
warning: error: unable to download 'https://gitlab.inria.fr/fpottier/fix/-/archive/20220121/archive.tar.gz': Couldn't connect to server (7); retrying in 1374 ms
warning: error: unable to download 'https://gitlab.inria.fr/fpottier/fix/-/archive/20220121/archive.tar.gz': Couldn't connect to server (7); retrying in 2[10](https://github.com/esy/esy/actions/runs/5428343543/jobs/9872745534#step:4:11)0 ms

@ManasJayanth
Copy link
Member Author

Fails with pnpm

Fatal error: exception Failure("Unable to resolve @prometheansacrifice/esy-bash/package.json from C:\\Users\\user\\AppData\\Local\\pnpm\\global\\5\\node_modules\\@esy-nightly\\esy\\3\\i\\esy-7c3d18e4\\bin\\")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant