Solver: lookup already installed opam package by name alone #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the ocaml compiler package uses a metadata tag (eg -musl.static.flambda or -afl), the solver which consists of two stages (opam and npm) erroneously requests two ocaml packages - the tagged one and the latest. This is explained as follows: During opam phases, the solver corrects requests the tagged package, but during the subsequent solve-naively phase (meant for npm), it fails to see find `ocaml@*` (TODO: doesn't seem right) and tries to fetch ocaml@* too
ManasJayanth
force-pushed
the
prometheansacrifice/lookup-opam-installed-by-name
branch
from
2d67ffa
to
0fe9e62
Compare
|
I think this should not be applied in the general case, only for OCaml itself, |
|
I'm more worried about the why |
|
@ManasJayanth Could this also be the issue behind my lockfile problems in #1349 ? Often those packages will use tagged packages to vary between different os/arch support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the ocaml compiler package uses a metadata tag (eg
-musl.static.flambda or -afl), the solver which consists of two
stages (opam and npm) erroneously requests two ocaml packages - the
tagged one and the latest.
This is explained as follows:
During opam phases, the solver corrects requests the tagged package,
but during the subsequent solve-naively phase (meant for npm), it
fails to see find
ocaml@*(TODO: doesn't seem right) and tries tofetch ocaml@* too