Auto clone esy-solve-cudf submodule #1324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems great! I was having an issue yesterday in that I had outdated submodules which caused esy to build incorrectly and fail when I ran it. |
1. We commonly forget to clone the submodule. Esy builds just fine without it, but without the esySolveCudfCommand which causes confusion while running tests. Core devs who work on it may not find it inconvenient, but newcomers may have difficulty. Why stop at documenting alone when tooling can get us past the hurdle 2. Document cloning submodules
ManasJayanth
force-pushed
the
prometheansacrifice/auto-clone-submodule
branch
from
255b0ff
to
2a506b2
Compare
ManasJayanth
force-pushed
the
prometheansacrifice/auto-clone-submodule
branch
from
df93512
to
0f38d0f
Compare
|
Thanks for this, only reason why 0.6.9 didn't happen is because I forgot to add cudf to the macOS arm64 build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverages Dune rules to auto clone
esy-solve-cudf