Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: always git shallow clone #1286

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anmonteiro
Copy link
Contributor

This proposal lifts the restriction that you can only shallow clone long hashes. I'm not aware of all the implications, though, so I appreciate folks chiming in if this is a no-go.

@anmonteiro
Copy link
Contributor Author

I just ran the github slow test locally, and it worked 👍

@EduardoRFS
Copy link
Collaborator

I also think this is reasonable. If we hit a problem we can revert it.

@ManasJayanth
Copy link
Member

ManasJayanth commented Apr 10, 2021

I want to take another at it this weekend

@EduardoRFS
Copy link
Collaborator

@ManasJayanth I think we can merge this as soon as the CI is green

@ManasJayanth
Copy link
Member

revParse can be removed safely (but I don't think we gain much by doing so)

The if block needs to stay

git clone https://github.com/esy/esy --depth 1
cd esy
git fetch https://github.com/esy/esy 802803c0 # fails
git fetch https://github.com/esy/esy 802803c00ea244536b6b4ceab7a14a75dd16b1d5 # succeeds

I think my revParse comment was unrelated to the codebase - sorry cant remember!

Not sure why the e2e didn't fail. Needs to be looked into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants