Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fos 55/events styling #381

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

markconroy
Copy link
Member

Adds some layout tweaks to events listing page, so it now looks like this:

Screenshot 2024-01-31 at 14-32-58 Events Essex County Council

@Polynya
Copy link
Collaborator

Polynya commented Feb 1, 2024

Please make the theme changes in ecc_theme

@markconroy
Copy link
Member Author

Please make the theme changes in ecc_theme

I don't want to put any changes for the theme into ecc_theme until that theme has gotten to live.

@markconroy
Copy link
Member Author

Marking as blocked until shared theme gets to main

@markconroy markconroy marked this pull request as draft February 12, 2024 16:41
@markconroy
Copy link
Member Author

I've added "Add to calendar" functionality, so marking this as draft until we get that tested.

@markconroy markconroy marked this pull request as ready for review February 21, 2024 17:35
@markconroy
Copy link
Member Author

Thanks @Polynya, I've made those changes now.

@Polynya
Copy link
Collaborator

Polynya commented Feb 22, 2024

Thanks @markconroy. Can we keep your 4 PRs open for now, until we know what is going to be deployed to Prod first, Fostering or Theme Sharing.

@Polynya
Copy link
Collaborator

Polynya commented Mar 19, 2024

@markconroy the shared theme has finally be deployed to Prod. The Essex theme is no longer used and will be deleted from this repo (LP-59). Please move the styling from this PR to https://github.com/essexcountycouncil/ecc_theme

If the styles are unique to Gov then put them in ecc_theme_gov but if they could be used by Intranet in the future then they should go in ecc_theme, the shared base theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants