Add fullscreen mode and widgets to line_clock app #3381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line_clock app now has a fullscreen mode configurable through settings. The visible widgets are adjusted according to the screen mode set by the user. A new function 'drawWidgets' has been introduced to facilitate this feature.
deepDiverPaul
referenced
this pull request
Apr 24, 2024
The `settings` object has been renamed to `initialSettings` for better clarity as these values represent the initial, default settings. Also, the code to remove the clock UI has been commented out, possibly signaling future work on applying the Fast Load system, but this needs to be confirmed. Lastly, calling settings to draw locking and minute indicators has been updated to call the renamed `initialSettings` object.
bobrippling
reviewed
Apr 24, 2024
| if(isFullscreen()){ | ||
| widget_utils.hide(); | ||
| } else { | ||
| Bangle.drawWidgets(); |
There was a problem hiding this comment.
Here can we use widget_utils.show() to undo any other changes it might've made?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line_clock app now has a fullscreen mode configurable through settings. The visible widgets are adjusted according to the screen mode set by the user. A new function 'drawWidgets' has been introduced to facilitate this feature.