Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom step #85

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Custom step #85

wants to merge 2 commits into from

Conversation

kefirbandi
Copy link
Contributor

James,

this is the functionality I mentioned before.
This allows the usage of node.custom_step('friend') or `node.custom_step('out.out').

I made a few changes, which I believe are rather independent from the implementation details of lower layers. I send them in different pull requests.

@espeed
Copy link
Owner

espeed commented Apr 24, 2013

Thanks. I'll look at this more when I have some time...not sure I understand the use case here. You can already do a custom step (one that's not stored in a .groovy file) via:

>>> g.gremlin.query("g.v.(id).out.out", {id: 1})

@kefirbandi
Copy link
Contributor Author

I agree. This is a convenience feature.
It comes especially handy in cases when you don't have direct access to "g".
For example in the class definition of a model, where you now have to write something like

a=self._client.gremlin("g.v(id).out.out", {'id': self.eid})
b=initialize_elements(self._client,a)

Instead it is simpler to write

b=self.custom_step("out.out")

This and the other pull requests are some features which I use, so I thought I share them with you. I am happy if these (or some variations) become part of the main line (like #90), but is absolutely no problem for me if for any reason you have a different opinion.

@espeed
Copy link
Owner

espeed commented May 22, 2013

A similar method existed in Bulbs 0.2 and I removed it to simply the code in Bulbs 0.3 when I reworked the Gremlin module:

https://github.com/espeed/bulbs/blob/0.2.x/bulbs/element.py#L143

Let's hold off on this for now -- I have an ideas for how to simply Gremlin calls from Models that may make this approach unnecessary .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants