Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added badges to apps #1418

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Added badges to apps #1418

wants to merge 3 commits into from

Conversation

zealot128
Copy link
Contributor

@zealot128 zealot128 commented Jan 29, 2019

I've added 2 badge types that are available for each app.
Badges are a nice way to communicate quality in a README etc.

Thinks that I am not so sure/could be optimized (if somebody wants to help, please feel free!)

  • authenticated key -> I've reused the key usage from the atom feed... that makes the token quasi public, and might be a problem when the Atom feed contain sensitive info. Maybe generate a new token per app only for badge usage?
    • Right now, we will only use the badges in private projects, so for us not urgent, but definitely preferable
    • update: added environment BADGE_PUBLIC which the user can decide which approach is more suitable
  • Badge Ranges... I've just made some guesses. Not sure how merged problems fell into that etc.
    • Would be great to make the ranges configurable via ENV config etc. (maybe later)
  • only added 2 smoke tests, had not the time to add thorough test of the logic (as ranges not sure right now)
  • other badge ideas? class infrastructure is there to add other badge types easily

bildschirmfoto 2019-01-29 um 22 46 25
bildschirmfoto 2019-01-29 um 22 46 29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant