Convert gif to webm #151
Merged
Convert gif to webm #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command: ffmpeg -i template-report.gif -c vp9 -b:v 0 -crf 40 template-report.webm
As it is already used by R
|
I'm stumped here. This works locally. The video is encoded in base64 and embedded directly in the page, without the need for external resources. But for some reason, it looks like it's not working here. The best option may be to revert to |
|
So I double checked and the pkgdown issue is a false positive. I have removed the 2 latest commits that seemed to create a new issue and removed the check. This is working as intended and ready to be merged from what I can tell. |
GeraldineGomez
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command: ffmpeg -i template-report.gif -c vp9 -b:v 0 -crf 40 template-report.webm
It took a bit of fiddling to get pkgdown to play nice with videos but I think I got it to work.