Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: vaChip story example with link #4134

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Alisheroffalex
Copy link
Contributor

PR closes #4072

In storybook example with link was router-link so it was doing nothing. Updated it so it will open the same storybook page in the new tab so it demonstrates functionality.

P.S I think making cursor for VaChip pointer when it is a link or clickable element is a way to go

@m0ksem
Copy link
Contributor

m0ksem commented Jan 10, 2024

I think issue not with story, but in VaChip. to prop must work.

@Alisheroffalex
Copy link
Contributor Author

@m0ksem As I understood the to prop is working correctly. The reason it is not working properly is vue-router not being used and there are not such routes defined. That's why I changed storybook example into external link

@m0ksem
Copy link
Contributor

m0ksem commented Jan 10, 2024

@m0ksem As I understood the to prop is working correctly. The reason it is not working properly is vue-router not being used and there are not such routes defined. That's why I changed storybook example into external link

In case if vue-router isn't available we use href... So the logic is:

NuxtLink if in nuxt
RouterLink if there is vue-router
a tag and href by default.

Basically, to prop should work in any environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VaChip link prop doesn't seem to work
2 participants