Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete mobileFullscreen prop #4094

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

VasylHryha
Copy link
Contributor

@VasylHryha VasylHryha commented Dec 14, 2023

Description

I propose removing the mobileFullscreen feature, as it leads to unclear behavior. In examining other UI frameworks like Vuetifyjs, Native UI, and Quasar, I found that they typically adjust modals to fit the window width rather than using a fullscreen mode on mobile. I've implemented this behaviour here: #4093. As an alternative to mobileFullscreen, I recommend using the fullscreen prop, which offers clearer and more consistent functionality.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@VasylHryha VasylHryha self-assigned this Dec 14, 2023
@VasylHryha
Copy link
Contributor Author

Yauheni Prakopchyk approved this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant