Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- feat: update google fonts to material symbols #4085

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

- feat: update google fonts to material symbols #4085

wants to merge 7 commits into from

Conversation

VasylHryha
Copy link
Contributor

@VasylHryha VasylHryha commented Dec 12, 2023 •
edited

Close #3848

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@VasylHryha VasylHryha self-assigned this Dec 12, 2023
@VasylHryha VasylHryha marked this pull request as draft December 12, 2023 16:08
@VasylHryha VasylHryha marked this pull request as ready for review December 12, 2023 16:23
VasylHryha
VasylHryha commented Dec 15, 2023
View reviewed changes
packages/docs/nuxt.config.ts
@@ -105,8 +105,7 @@ export default defineNuxtConfig({
'Source+Code+Pro': {
wght: [400],
},
'Material+Icons': true,
'Material+Icons+Outlined': true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick check with docs, look fine

m0ksem
m0ksem requested changes Dec 22, 2023
View reviewed changes
packages/create-vuestic/src/steps/2.addVuestic/vue-app.ts
@@ -41,7 +41,7 @@ export const addVuesticToVue3App = async () => {
let htmlSource = await readFile(htmlPath, 'utf-8')
htmlSource = insertHead(htmlSource, [
`<link href="https://fonts.googleapis.com/css2?family=Source+Code+Pro&family=Source+Sans+Pro:wght@400;700&display=swap" rel="stylesheet">`,
`<link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">`
`<link href="https://fonts.googleapis.com/icon?family=Material+Symbols+Outlined" rel="stylesheet">`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update IconsConfig to use material-symbols but default, instead of material icons.
I expect updating nuxt module in my project and all icons still work, even if the're symbols now.

Right now, creating new vuestic project will install Material Symbols, but we use material-icons in IconsConfig...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should release both projects simultaneously then.

@VasylHryha
Copy link
Contributor Author

Replaced Material Icons -> Material Symbols Outlined almost everywhere
Docs looks fine

Please check to make sure I haven't replaced icons where I shouldn't have, or if there are places where we still need Material Icons.

@m0ksem
Copy link
Contributor

m0ksem commented Dec 27, 2023

I think we don't need Material Icons anymore anywhere. We just need to make sure we use symbols everywhere. The next release is gonna be 1.9.0 where we can introduce breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvae asvae Awaiting requested review from asvae

@m0ksem m0ksem Awaiting requested review from m0ksem

Assignees

@VasylHryha VasylHryha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update google fonts to material symbols
3 participants
@VasylHryha @m0ksem @asvae