Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docs related sliders overflow #3852

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Stars22
Copy link

@Stars22 Stars22 commented Sep 11, 2023

  • fixes related slider overflow: when the top slider value(set to min) becomes greater then the max value of bottom sliders close VaSlider goes overflow #3819

image

@@ -1,12 +1,12 @@
<template>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to fix it.

image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, my bad. missed the second slider. fixed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so we fixed the docs example. We didn't fix the underlying issue.

Range should be operational even if min/max are swapped. It's reasonable to expect user would do something similar in app.

We could either fix it in this PR or move to another issue, but this has to be addressed.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. I think it's right to have fix in this pr. I'll check what we can do.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created a possible solution, I can't say how it's optimal as it was not a trivial task to begin with )

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

story is kind of draft not intended for merge, maybe will be helpful to play around with sliders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VaSlider goes overflow
2 participants