Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VaDatePicker a11y #3747

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

Roman4437
Copy link
Collaborator

closes #3744

added essential roles and attributes

@Roman4437 Roman4437 requested a review from m0ksem August 27, 2023 16:05
Copy link
Contributor

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use format prop in aria-label.

Also, why did you skip role "presentation", "aria-live " and "aria-atomic"? We change grid using arrow buttons, so it must be applied here I think (Im not sure).

These changes also must be applied to months picker and something must be changed in year picker.

@Roman4437 Roman4437 requested a review from m0ksem August 28, 2023 11:47
@m0ksem
Copy link
Contributor

m0ksem commented Aug 29, 2023

I checked out that gridcell must be used in row. It is a requirement, otherwise gridcell will not be recognized. We're using css grid here, so we don't have an actual row element...

I think we need to change component layout from css grid, to more general approach with row

roles:

grid
  row
     columnheader <- weekdays
  rowgroup
     row
       gridcell <- date

What if we make VaGrid component, which will implement all of these with keyboard navigation? I think it might be useful for people who make something like cinema chair picker or whatever requires navigation with grid. We could reuse VaGrid in DatePicker. I think for this PR we can simply remove wrong roles and implement VaGrid component later.

@m0ksem m0ksem mentioned this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

a11y: va-date-picker
2 participants