va-skip-link #3720
Open
va-skip-link #3720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asvae
requested changes
Aug 22, 2023
asvae
reviewed
Aug 25, 2023
asvae
reviewed
Aug 25, 2023
asvae
reviewed
Aug 25, 2023
packages/docs/page-config/ui-elements/skip-link/examples/Default.vue
Outdated
Show resolved
Hide resolved
asvae
requested changes
Aug 25, 2023
asvae
reviewed
Aug 29, 2023
|
|
||
| block.subtitle("Basic usage"), | ||
|
|
||
| block.paragraph("By default, `va-skip-link` needs a target and position, please keep in mind that the component should be placed as the very first element."), |
There was a problem hiding this comment.
Can we add a short code example here? Just code. Right now it's not clear at all how to use component.
asvae
reviewed
Aug 29, 2023
| export default definePageConfig({ | ||
| blocks: [ | ||
| block.title("Skip Link"), | ||
| block.paragraph("`va-skip-link` skip to the target component."), |
There was a problem hiding this comment.
We need more text here. You can describe in technical terms what component does - then ask chat gpt to get you some text.
|
We agreed I'll help with docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VaSkipLink component and stories
close #3658