Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VaChip link prop doesn't seem to work #4072

Open
asvae opened this issue Dec 6, 2023 · 3 comments · May be fixed by #4134
Open

VaChip link prop doesn't seem to work #4072

asvae opened this issue Dec 6, 2023 · 3 comments · May be fixed by #4134
Labels
BUG Something isn't working d1: super easy Task for newbies. Players take half normal damage from monsters and the environment. good first issue Right issue if you're new to vuestic v1: minor This might be helpful, but not really

Comments

@asvae
Copy link
Contributor

asvae commented Dec 6, 2023

Vuestic-ui version: 1.8.5

Steps to reproduce

https://ui-storybook-develop.vuestic.dev/?path=/story/vachip--default

image

What is the expected behavior?

Click should open another page

What is the current behavior?

Click does nothing

Other information
@asvae asvae added BUG Something isn't working good first issue Right issue if you're new to vuestic d1: super easy Task for newbies. Players take half normal damage from monsters and the environment. v1: minor This might be helpful, but not really labels Dec 6, 2023
@emperorsegxy
Copy link
Contributor

I think this works as expected.

The only time it would open a new page is when these props are passed — 'href' and 'target' is '_blank'

@asvae
Copy link
Contributor Author

asvae commented Dec 25, 2023

We should fix story then. Clicking does nothing.

Story should always represent functionality and in this case the functionality is exactly the same as for Default.

@3aluw
Copy link
Contributor

3aluw commented Jan 4, 2024 •
edited

There is something wrong here.
it is not working on the playground nor on storybook. The console shows router-link tag :

Capture2

while it works on documentation and it is rendered as an a tag :

Capture3

@Alisheroffalex Alisheroffalex linked a pull request Jan 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BUG Something isn't working d1: super easy Task for newbies. Players take half normal damage from monsters and the environment. good first issue Right issue if you're new to vuestic v1: minor This might be helpful, but not really
Projects
Vuestic Sprint (7 September - 21 September)
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: vaChip story example with link Alisheroffalex/vuestic-ui
3 participants
@asvae @emperorsegxy @3aluw