Add CertProvider to hot reload TLS certs for gRPC service #587
+136
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a goruntime instance to watch for on disk changes of gRPC certificates. Certificates will be reloaded in case of change and the gRPC service will always fetch the latest one via GetCertificate instead of the static Certificates slice. Bug: T362310 Change-Id: I24ca45820021744670d204c6bea41dd1b8303ac8 Signed-off-by: Janis Meybohm <jmeybohm@wikimedia.org>
mattklein123
requested changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a goruntime instance to watch for on disk changes of gRPC certificates.
Certificates will be reloaded in case of change and the gRPC service will always fetch the latest one via GetCertificate on new connections instead of the static Certificates slice.