Initial integration of DogStatsD #585
Open
+382
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
including something called mogrifiers Signed-off-by: JDeuce <jjaques@gmail.com>
Signed-off-by: JDeuce <jjaques@gmail.com>
Signed-off-by: JDeuce <jjaques@gmail.com>
Signed-off-by: JDeuce <jjaques@gmail.com>
|
I apologize for making a design comment on an already implemented PR but what if instead of continuing to build support for specific company / vendor formats we instead implemented vendor-neutral OTEL Metrics ? |
mattklein123
requested changes
Jun 7, 2024
Comment on lines
+47
to
58
| } else if s.UseDogStatsd { | ||
| var err error | ||
| sink, err := godogstats.NewSink( | ||
| godogstats.WithStatsdHost(s.StatsdHost), | ||
| godogstats.WithStatsdPort(s.StatsdPort), | ||
| godogstats.WithMogrifierFromEnv(s.UseDogStatsdMogrifiers)) | ||
| if err != nil { | ||
| logger.Fatalf("Failed to create statsd sink: %v", err) | ||
| } | ||
| logger.Info("Stats initialized for dogstatsd") | ||
| store = gostats.NewStore(sink, false) | ||
| } else if s.UseStatsd { |
There was a problem hiding this comment.
Can you make it an error if someone sets both dogstatsd and statsd to true?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
godogstatspackage is implemented to bridgelyft/gostatswith dogstatsd.There is a new statsd sink implemented which will output the stats using dogstatsd protocl over UDP which allows tags.
Thus, a new
mogrificationfeature is also added which lets us mogrify the stat from internal metric names, into a different name + tags, similar to what is done in the prom-stats-exporter exampleNote: there is some runtime cost associated with mogrifying the metrics but it should be minimal due to the existing in memory flushing architecture.