Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(styling): refactor from CSS modules to Tailwind #1496

Merged
merged 35 commits into from May 3, 2024
Merged

Conversation

emilielr
Copy link
Collaborator

@emilielr emilielr commented Apr 25, 2024

  • Add color in tailwind config.
  • Removed all of the modules.css files from /app and /pages folder (/src are still left but I have created a seperate task for this as it is still 10-15 files left..)
  • Added a defualt value to borderRadius as 0.5em is most often used and a global variable for secondary + tertiary bakgorund color.
  • Also fix buttons on /edit to align with text and icon:
    image

Jalla-chromium:
image

@emilielr emilielr changed the title WIP chore(styling): refactor from CSS modules to Tailwind chore(styling): refactor from CSS modules to Tailwind Apr 25, 2024
@emilielr emilielr marked this pull request as ready for review April 25, 2024 12:27
@emilielr emilielr requested review from purusott and oyvindgrutle and removed request for purusott April 25, 2024 12:27
Copy link
Collaborator

@oyvindgrutle oyvindgrutle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

Copy link
Collaborator

@purusott purusott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 ⭐

next-tavla/src/Shared/utils/firebase.ts Outdated Show resolved Hide resolved
next-tavla/tailwind.config.ts Show resolved Hide resolved
next-tavla/tailwind.config.ts Outdated Show resolved Hide resolved
next-tavla/src/Shared/components/TravelTag/index.tsx Outdated Show resolved Hide resolved
next-tavla/src/Shared/components/TravelTag/index.tsx Outdated Show resolved Hide resolved
next-tavla/src/Shared/utils/firebase.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@lindtvedtsebastian lindtvedtsebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Det er sikkert bra nå, vi får heller fikse ting som dukker opp

@emilielr emilielr merged commit 47a4c0d into master May 3, 2024
5 checks passed
@emilielr emilielr deleted the tailwind-fixes branch May 3, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants