Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(board): information footer on board #1486

Merged
merged 40 commits into from May 13, 2024
Merged

feat(board): information footer on board #1486

merged 40 commits into from May 13, 2024

Conversation

oyvindgrutle
Copy link
Collaborator

@oyvindgrutle oyvindgrutle commented Apr 10, 2024

Screenshot 2024-04-10 at 10-07-13 Entur Tavla
Screenshot 2024-04-23 at 10-01-38 Hold kjeft Entur Tavla
image

next-tavla/src/Shared/components/Footer/index.tsx Outdated Show resolved Hide resolved
next-tavla/pages/[id].tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@purusott purusott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Har jeg forstått det rett, vil:

  • footer satt i en organisasjon vises på alle tavler (og fremtidige)
  • footer endringer i edit/.. gjelde for tavlen og overskrive organisasjonsfooter

Skal vi ta hensyn til organisasjoner som vil ha en default footer, og samtidig ha noen tavler uten footer?

@oyvindgrutle
Copy link
Collaborator Author

Ja, jeg tenkte tanken. Kunne eventuelt hatt en switch (som med gåavstand) for å velge om den skal vises eller ikke.

@purusott
Copy link
Collaborator

Godt forslag! Det er ikke noe som må fikses nå for min del 😄 spørs hva de andre synes 💭

@emilielr
Copy link
Collaborator

Når man lager en ny tavle i en organisasjon hvor man har satt en infomelding, så settes ikke teksten i tekst-feltet når man skal redigere tavlen. Den vises i tavlevisningen, men hadde vært kjekt at det også vistes i selve tekst-feltet, så brukeren vet at det står noe der (og hva), uten å måtte gå på selve tavle-visningen

image

@emilielr
Copy link
Collaborator

En switch kan være nice for å velge om man vil ha footer eller ikke i det hele tatt. Jeg stemmer for at vi legger det som et nytt kort i boardet, også får vi denne inn nå 🚀

@oyvindgrutle oyvindgrutle requested review from lindtvedtsebastian and removed request for lindtvedtsebastian April 17, 2024 14:05
@oyvindgrutle oyvindgrutle requested review from lindtvedtsebastian and removed request for lindtvedtsebastian May 8, 2024 12:17
next-tavla/pages/[id].tsx Outdated Show resolved Hide resolved
next-tavla/src/Shared/components/Footer/index.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@lindtvedtsebastian lindtvedtsebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeg syntes du skal

next-tavla/src/Shared/components/Footer/index.tsx Outdated Show resolved Hide resolved
@oyvindgrutle oyvindgrutle merged commit cf566fb into master May 13, 2024
5 checks passed
@oyvindgrutle oyvindgrutle deleted the footer branch May 13, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants