Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: uncaught exceptions from createUpdaters will halt subscription retries #168

Merged
merged 4 commits into from
Apr 26, 2024
Merged

fix: uncaught exceptions from createUpdaters will halt subscription retries #168

merged 4 commits into from
Apr 26, 2024

Conversation

testower
Copy link
Collaborator

@testower testower requested a review from hbruch April 26, 2024 12:17
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 26, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

hbruch
hbruch approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@hbruch hbruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@testower testower merged commit 528ac46 into master Apr 26, 2024
3 checks passed
@testower testower deleted the fix/catch-exceptions-from-create-updaters branch April 26, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbruch hbruch hbruch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@testower @hbruch