Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resetting of the error state for FileEditor #2007

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

greschd
Copy link
Contributor

@greschd greschd commented Apr 6, 2023

Reset the 'error' state of the file editor when its value changes. Previously, the state would remain
as error, which means the value cannot be set.

Created as draft because this only implements it for wx, whereas qt has the same issue.

The code block of the _reset_error function

if self._error is not None:
    self._error = None
    self.ui.errors -= 1 
    self.set_error_state(False)

is then present in four places: text_editor and file_editor for both qt and wx. Since I'm not really familiar with the overall architecture of the code: What's the best place to put this? Or should I keep it separate?

Reset the 'error' change of the file editor when its
value changes. Previously, the state would remain
as error, which means the value cannot be set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant