Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GuiTestAssistant and add it to the testing API #304

Open
5 tasks
mdickinson opened this issue Apr 15, 2021 · 3 comments
Open
5 tasks

Rename GuiTestAssistant and add it to the testing API #304

mdickinson opened this issue Apr 15, 2021 · 3 comments
Labels
type: enhancement New feature or request
Milestone

Comments

@mdickinson
Copy link
Member

mdickinson commented Apr 15, 2021

We should rename the GuiTestAssistant (the one in Traits Futures, not the one in Pyface) to avoid confusion, polish it up, document it, and make it available to users, possibly under a new traits_futures.testing.api module.

See also #252.

Subtasks:

@kitchoi
Copy link

kitchoi commented Apr 15, 2021

👍 on renaming. The core of this is a dependency of an event loop, in theory, any event loop (e.g. it can be asyncio or tornado event loop in the context of a web server). Reading GuiTestAssistant in a test case that is not targeting GUI raises false alarm.

@mdickinson
Copy link
Member Author

Yes, renaming is a no-brainer. (The existing name is historical: at one point the GuiTestAssistant we were using actually was the Pyface version, then it was a cut-down version of the Pyface version, then a modified cut-down version, extended to cover wx and asyncio, .... It's definitely due a rename.)

Note that there are also some pending changes in #299, which will make the GuiTestAssistant toolkit independent and move the underlying event loop management into a toolkit dependent piece.

@mdickinson
Copy link
Member Author

The renaming has been done. I'm going to defer the rest of this to the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants