Adding some aliases #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added common aliases and definitions of power
scimath/units/electromagnetism.py
Outdated
| @@ -23,19 +30,25 @@ | |||
| ############################################################################### | |||
|
|
|||
| volts = volt | |||
| v = volt | |||
There was a problem hiding this comment.
Can you keep existing definitions - removing them will break existing code that expects them.
|
Test failures are because of removed unit types. |
|
This is generally fine, and I would be Ok with merging this, but we need to keep backward compatibility even if we have some synonyms which are not precisely the right thing. |
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
==========================================
+ Coverage 60.9% 62.03% +1.13%
==========================================
Files 75 75
Lines 3210 3306 +96
Branches 368 368
==========================================
+ Hits 1955 2051 +96
Misses 1163 1163
Partials 92 92
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some aliases in the unit scripts for better usability...