Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add height into cylinder_actor. #883

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Doradx
Copy link

@Doradx Doradx commented Jan 5, 2020

add optional parameter 'height' into cylinder_actor.

add optional parameter 'height' into cylinder_actor.
@codecov-io
Copy link

codecov-io commented Jan 5, 2020

Codecov Report

Merging #883 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #883      +/-   ##
==========================================
+ Coverage   50.85%   50.86%   +<.01%     
==========================================
  Files         263      263              
  Lines       23846    23843       -3     
  Branches     3252     3251       -1     
==========================================
  Hits        12128    12128              
+ Misses      10931    10928       -3     
  Partials      787      787
Impacted Files Coverage Δ
tvtk/pyface/actors.py 0% <0%> (ø) ⬆️
mayavi/tools/data_wizards/data_source_wizard.py 0% <0%> (ø) ⬆️
mayavi/tools/data_wizards/data_source_factory.py 0% <0%> (ø) ⬆️
tvtk/wrapper_gen.py 11.01% <0%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8377bd1...4cce741. Read the comment docs.

tvtk/pyface/actors.py Show resolved Hide resolved
tvtk/pyface/actors.py Show resolved Hide resolved
Copy link
Author

@Doradx Doradx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add space before ',' and rename 'resolution' to 'heiresolution'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants