Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: fix non integer shape #1253

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MAINT: fix non integer shape #1253

wants to merge 1 commit into from

Conversation

homosapien-lcy
Copy link

After previous python updates, division no longer yields integer type, this has caused problems such as in #1244. This PR is aiming to fix this by add integer castings. closes #1244

prabhuramachandran
prabhuramachandran requested changes May 15, 2023
View reviewed changes
Copy link
Member

@prabhuramachandran prabhuramachandran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I think it would be nicer to use pts.size//3, 3 rather than an explicit cast to an int.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhuramachandran prabhuramachandran prabhuramachandran requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@homosapien-lcy @prabhuramachandran